Depends on D1748
Lots of comments, most of them details and polishing, and me not understanding things.
This bindProperty mechanism .. is pretty complex, and I don't think we'll use it again very soon.
It's cool to see what you can do with Python, but please avoid doing complex things like this unless it's really necessary.
You could have very well connected manually to the self.engine's property to monitor when the setting should be updated.
Make sure you are always using quotes for strings, for consistency. Except when the string has quotes, in this case in other places we use '.
Add a comment to explain the reason why we load the plugins only after the window is added.
Add a comment to explain why this binding is done, something like:
# Bind the engine's loaded-plugins property so when a plugin # is loaded or unloaded, the updated list of loaded plugins is stored # in the PluginsActivePlugins setting.
Maybe rename the method to _load_plugins(names) and pass the argument here.
First line of a pydoc must be a complete sentence with dot at the end.
Maybe change the condition on line 224 from if value is not None to if value so you don't do it here.
This should be in a "Raises:" section. run this for examples:
There is no point if using elif, use if
Isn't it better to separate things in methods when possible?
I might be wrong but I think it will never be used again, and being too sophisticated, it's better to keep it in the other place. I could have removed them but if you read them it won't harm. :)
What should I do with the docstring? Do I put it as a big comment in the "elif" branch of _read_value/_write_value? Or I put it as part of the _read_value and _write_value's docstring? Or just I forget of it and I discard that documentation :) ?
Yes, it is the main window. It is needed when plugins are loaded from settings. When you start Pitivi and you load plugins from settings, for example the developer console, it needs to access part of the main window, but by that time the main-window doesn't exist yet.
Actually, I think that it would be better to load plugins from settings when "everything" has loaded in Pitivi.