Depends on D1790
why is this necessary?
Add a pydoc to explain when it should be used.
why try instead of elif type_ == Gdk.RGBA:?
newline above, for consistency
Why is this needed?
These descriptions above are not really useful. Is it possible to remove them?
Hm, not sure how we can do this, but it would be good if we can not go through app.gui to the preferences_dialog.
Why do we raise in removeSection? If the section is already gone, we should just do nothing. Could you please make it more friendly?
You seem to pass self.terminal only because the handlers are classmethods. Make them normal methods which receive self, and they can access self.terminal then?
Change the names of the new methods to use the new style
Why is this needed?
Shouldn't these default values better be defined where we define the settings which store them? Then we can use the settings .. (which we already do somewhere else?)
- When copying text from the developer console and pasting it in the >>> line, it appears colored - it should appear the prompt color
- IMO there should be 3 colors of the text
- input (what the user writes)
.. but now I see that the current >>> line has a different color than the past >>> lines. Any reason to have them different colors?
I actually don't know why there is this line in Pitivi
value = type(value)(real_widget.getWidgetValue())
This is used for Gdk.RGBA color, because type(value), gives you a Gdk.RGBA. Then if you do something like Gdk.RGBA(real_widget.getWidgetValue()), it will fail because getWidgetValue will return a Gdk.RGBA.
And a Gdk.RGBA doesn't receive Gdk.RGBAs
Because addConfigOption may raise many exceptions
I wanted to avoid mixing Pitivi stuff with the widget itself. But what should I do? It is a matter of tastes. And I was thinking that in a long-term future I can add this plugin to other GNOME apps, but maybe that will never happen. Again, what do I do?
Ok, but why is it needed to ignore those exceptions?
The added complexity is worth IMO.
Maybe use the modern API for storing settings in GNOME, I remember you wanted to use it in Pitivi.. Would that work? You could then use it as an example for future plugins.
It creates a new page as soon a section is created (a new blank container widget). Everytime a preference is added, it adds the respective preference widgets (one by one) to the blank container widget.