plugins: Add support for shortcuts commands in Developer Console
Needs ReviewPublic

Authored by cfoch on Jul 20 2017, 11:53 PM.

Details

Maniphest Tasks
T7784: Developer Console
Reviewers
thiblahute
aleb
Summary

Depends on D1828

Diff Detail

Repository
rPTV Pitivi
Branch
developer-console-code-module-phabricator
aleb requested changes to this revision.Jul 22 2017, 5:47 PM
aleb added inline comments.
plugins/console/console.py
44

"""Gets the Pitivi instance."""

50

"""Gets the Plugin Manager of the Pitivi instance."""

56

"""Gets the GES.Timeline of the current project."""

60

It could be layers, but IMO better to remove it, because - it's easy enough to use timeline.get_layers()

65

This could better be a method of the plugin manager. Then in the dev console we can use plugin_manager.get_extension(name) - with tab completion it should be fast to type.

80

I don't think this is useful - there are only a few of them and they are printed anyway at the start. And then there will also be the help URL which has the entire usage guide..

I'd say we should remove it.

88

heh, funny!

plugins/console/utils.py
58

"""Base for namespaces usable when executing a Python command."""

59

newline above?

plugins/console/widgets.py
81

if welcome_message is enough and looks more Pythony, not important..

This revision now requires changes to proceed.Jul 22 2017, 5:47 PM
cfoch added inline comments.Aug 22 2017, 5:47 PM
plugins/console/console.py
88

I want to make it explicit that "help" shouldn't be translated.

cfoch updated this revision to Diff 6408.Aug 27 2017, 7:16 AM
cfoch edited the summary of this revision. (Show Details)

Use code module

cfoch updated this revision to Diff 6427.Aug 28 2017, 8:56 PM

Missing if replacing after-prompt by command-start or prompt-start